Qual tool: Print more useful log messages when failures happen downloading dependencies #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
parthosa
reviewed
Aug 15, 2024
nartal1
reviewed
Aug 15, 2024
| @@ -387,14 +391,22 @@ class RapidsJarTool(RapidsTool): | |||
| """ | |||
|
|
|||
| def _process_jar_arg(self): | |||
| jar_path = '' | |||
There was a problem hiding this comment.
This seems redundant because the exception is re-raised if the jars are not downloaded successfully.
There was a problem hiding this comment.
can you clarify what you think is redundant here? Just the setting of jar_path? the main additions in this are the messages being printed not the exception stacks
There was a problem hiding this comment.
Yes, I meant we can remove setting the jar_path explicitly here. Sorry, it wasn't clear in my last comment.
parthosa
approved these changes
Aug 16, 2024
cindyyuanjiang
approved these changes
Aug 17, 2024
parthosa
added
the
user_tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #1286
Adds in some specific error handling and logging to help with errors downloading jars or not having access to external internet. This is specifically handling a few cases mentioned in the issue.
Tested by making the mvn url go to an invalid host.